Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pystemmer -> py-rust_stemmers #366

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Pystemmer -> py-rust_stemmers #366

merged 3 commits into from
Oct 21, 2024

Conversation

I8dNLo
Copy link
Contributor

@I8dNLo I8dNLo commented Oct 16, 2024

To avoid problems with PyStemmer installation and align to cloud version we are trying to remove PyStemmer with our rust-stemmers Python bindings

@joein
Copy link
Member

joein commented Oct 16, 2024

waiting for all the wheels to be uploaded to pypi, other than that - I think it is good to go

@joein joein self-requested a review October 21, 2024 19:45
@joein joein merged commit 69ffaa0 into main Oct 21, 2024
17 checks passed
@joein joein deleted the py-rust-stemmers branch October 21, 2024 19:46
@lambda-science
Copy link

This looks uncompatible with UV package manager and broke my docker image


RUN uv sync --no-install-project

warning: Skipping installation of entry points (`project.scripts`) because this project is not packaged; to install entry points, set `tool.uv.package = true` or define a `build-system`
Using Python 3.12.7 interpreter at:/usr/local/bin/python3
Creating virtual environment at: .venv
Resolved 151 packages in 2.72s
error: Failed to prepare distributions
Caused by: Failed to fetch wheel: py-rust-stemmers==0.1.1
Caused by: Build backend failed to build wheel through `build_wheel()` with exit status: 1
--- stdout:
Running `maturin pep517 build-wheel -i /tmp/.tmpepYANb/builds-v0/.tmphNFCWC/bin/python --compatibility off`
--- stderr:
� maturin failed
Caused by: Cargo metadata failed. Do you have cargo in your PATH?
Caused by: No such file or directory (os error 2)
Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/tmp/.tmpepYANb/builds-v0/.tmphNFCWC/bin/python', '--compatibility', 'off'] returned non-zero exit status 1
--- 

@lambda-science
Copy link

(Pinning fastembed <4.0 solved it)

@joein
Copy link
Member

joein commented Oct 22, 2024

@lambda-science hi, it should work with fastembed == 0.4.0
We introduced py-rust-stemmers in 0.4.1
Could you please show us your docker file so we could fix the problem with the newest version?

@lambda-science
Copy link

@lambda-science hi, it should work with fastembed == 0.4.0 We introduced py-rust-stemmers in 0.4.1 Could you please show us your docker file so we could fix the problem with the newest version?

Yes it's building fine with fastembed == 0.4.0

@joein
Copy link
Member

joein commented Oct 23, 2024

@lambda-science what base image are you using? Which OS? It seems that it can’t find the appropriate wheels and tries to build the package from scratch and then fails

@lambda-science
Copy link

@lambda-science what base image are you using? Which OS? It seems that it can’t find the appropriate wheels and tries to build the package from scratch and then fails

Linux Docker container, my base image is this:

FROM python:3.12-slim-bullseye
COPY --from=ghcr.io/astral-sh/uv:0.4.25 /uv /bin/uv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants