Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi gpu support #358

Merged
merged 22 commits into from
Oct 16, 2024
Merged

Multi gpu support #358

merged 22 commits into from
Oct 16, 2024

Conversation

hh-space-invader
Copy link
Contributor

No description provided.

Copy link
Member

@joein joein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments are mostly left for image embeddings, but they are relevant to all the model types

@joein joein force-pushed the multi-gpu-support branch from de7ddb6 to faf8c5e Compare October 11, 2024 19:03
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@joein joein changed the base branch from gpu to main October 11, 2024 19:04
@joein joein force-pushed the multi-gpu-support branch from 4e4d7fb to b28824b Compare October 11, 2024 19:11
Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on 4 GPU machine as expected
On 8 GPUs, the acceleration is below expected, but it looks like the bottleneck is somewhere else

hh-space-invader and others added 20 commits October 15, 2024 13:07
refactor: Refactor how worker assign device
* WIP: review

* wip: review

* refactor: refactor images

* refactor: refactor sparse

* refactor: refactor late interaction

* add model loading

* add tests

* fix: uncomment models in tests

* fix: fix variable declaration order

* fix: fix device id assignment

* tests: add multi gpu tests

* fix: fix device id assignment for sparse embeddings

* tests: update multi gpu tests

---------

Co-authored-by: George Panchuk <[email protected]>
@joein joein merged commit eaecf7d into main Oct 16, 2024
17 checks passed
@joein joein deleted the multi-gpu-support branch October 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants