Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when loading the cached dataset #8727

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fix error when loading the cached dataset #8727

merged 3 commits into from
Nov 28, 2024

Conversation

Met4physics
Copy link
Contributor

Solve this issue #8726

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8727

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @Met4physics!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Met4physics Met4physics mentioned this pull request Nov 13, 2024
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NicolasHug
NicolasHug reviewed Nov 27, 2024
View reviewed changes
references/video_classification/train.py Outdated
@@ -164,7 +164,7 @@ def main(args):

if args.cache_dataset and os.path.exists(cache_path):
print(f"Loading dataset_train from {cache_path}")
dataset, _ = torch.load(cache_path, weights_only=True)
dataset, _ = torch.load(cache_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Met4physics , I think the default of weights_only recently changed to None, so we might need to keep it hard-coded as weights_only=False

similar to what we do in the classification reference:

vision/references/classification/train.py

Line 131 in acbfd8d

dataset, _ = torch.load(cache_path, weights_only=False)

Do you mind updating this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! I have already updated this PR.

@Met4physics
Update train.py
afe0a4b 
fix error in video classification training
NicolasHug
NicolasHug approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Met4physics !

@NicolasHug NicolasHug merged commit 19fef3d into pytorch:main Nov 28, 2024
1 check passed
@github-actions GitHub Actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2025
@NicolasHug @facebook-github-bot
[fbsync] Fix error when loading the cached dataset (#8727)
4eb10cf 
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D68021964

fbshipit-source-id: e494a5413bb703a74510f9485267d7726f5ca26f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
bug cla signed module: reference scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Met4physics @facebook-github-bot @NicolasHug