Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom package name for CI builds of torchvision #8659

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

amd-jmacaran
Copy link
Contributor

@amd-jmacaran amd-jmacaran commented Sep 23, 2024

Mirroring what is done in the pytorch repo: https://github.com/pytorch/pytorch/blob/main/setup.py#L347

This is to accommodate custom package naming for CI builds if additional metadata is to be added, outside of the version string.

cc @seemethere

Copy link

pytorch-bot bot commented Sep 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8659

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit b42e4ab with merge base fc74637 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @amd-jmacaran!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks for the PR @amd-jmacaran

@NicolasHug NicolasHug merged commit 9832166 into pytorch:main Oct 2, 2024
65 of 68 checks passed
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2025
Reviewed By: vmoens

Differential Revision: D68021984

fbshipit-source-id: 4c0ac73e8270a46eda80268caa548d13e5da50dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants