Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly copying array in pil_to_tensor (#4566) #4573

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Explicitly copying array in pil_to_tensor (#4566) #4573

merged 1 commit into from
Oct 8, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 8, 2021 •
edited by pytorch-probot bot
Loading

@jdsgomes @NicolasHug @datumbox
Explicitly copying array in pil_to_tensor (pytorch#4566)
2edaba7 
* mExplicitly copying array in pil_to_tensor

* Update torchvision/transforms/functional.py

Co-authored-by: Nicolas Hug <[email protected]>

* Adding comments regarding implicit array deep copy in PILToTensor transform

* Update torchvision/transforms/transforms.py

Co-authored-by: Nicolas Hug <[email protected]>

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Vasilis Vryniotis <[email protected]>
NicolasHug
NicolasHug approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@datumbox
Copy link
Contributor Author

datumbox commented Oct 8, 2021

The failing tests are unrelated [1, 2]. We will merge this now and follow up to investigate the broken release branch.

@datumbox datumbox merged commit 254a216 into pytorch:release/0.11 Oct 8, 2021
@datumbox datumbox deleted the cherrypick/fix_np_warning branch October 8, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
ciflow/default module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datumbox @NicolasHug @fmassa @jdsgomes