Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum required shapes for classification model builder. #3944

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

ganler
Copy link
Contributor

@ganler ganler commented Jun 1, 2021

Document minimum required shapes for classification model builder whose minimum size is greater than one.

See discussion: #3921
See experiment: https://colab.research.google.com/drive/1T3_M55A75-b2FHaOWs8wYrmlM8gd3lgp?usp=sharing

@facebook-github-bot
Copy link

Hi @ganler!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ganler
Copy link
Contributor Author

ganler commented Jun 1, 2021

CLA signed.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganler LGTM, thanks for your contribution!

@datumbox datumbox merged commit d1f1a54 into pytorch:master Jun 1, 2021
facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2021
…ilder. (#3944)

Summary:
* [doc] add minimum input size for alexnet builder

* [doc] add minimum input size for vgg builder

* [doc] add minimum input size for squeezenet builder

* [doc] add minimum input size for densenet builder

* [doc] add minimum input size for inception_v3 builder

* [doc] add minimum input size for googlenet builder

Reviewed By: NicolasHug

Differential Revision: D29027304

fbshipit-source-id: 90b3bc550deed58b3b4a3863c39b10676462dd74

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants