addressing #3805: remove deprecated function call 3 #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjuncek
changed the title
| @@ -7,13 +7,13 @@ namespace ffmpeg { | |||
|
|
|||
| namespace { | |||
| bool operator==(const AudioFormat& x, const AVFrame& y) { | |||
| return x.samples == y.sample_rate && x.channels == y.channels && | |||
| return static_cast<int>(x.samples) == y.sample_rate && static_cast<int>(x.channels) == y.channels && | |||
There was a problem hiding this comment.
This line causes clang_format error: https://app.circleci.com/pipelines/github/pytorch/vision/8395/workflows/8f202b72-937b-4c98-b642-1e679e41b5c7/jobs/604228, could you fix that please?
prabhat00155
added a commit
that referenced
this pull request
Jun 7, 2021
This reverts commit f6b6b51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #3805
split in multiple PRs to make assesing FBCode compatibility easier for @prabhat00155
This should cover most warnings that are one liners and shouldn't change the code's behaviour.