-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved utilites, adds examples, tests #3594
Conversation
Almost there! Since we modified I am adding this to the examples folder, not as anonymous gist. The advantage is that this can be version controlled as well as modified by anyone with a simple PR!
@datumbox I remember getting nice output on persons. See here! Can we use this image for showing the segmentation masks demonstration? It would be really nice. Edit: I'm currently using a sample COCO image which was also used in DETR Colab demo. It too looks nice. |
Feel free to review the PR! Here is a link to the rendered notebook. For bounding boxes, let me know if I should change the image to image as used in segmentations. The tests just improve code coverage, I have just added corner cases of errors and some lines which weren't tested earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
==========================================
+ Coverage 79.33% 79.69% +0.36%
==========================================
Files 105 105
Lines 9822 9822
Branches 1582 1582
==========================================
+ Hits 7792 7828 +36
+ Misses 1538 1517 -21
+ Partials 492 477 -15
Continue to review full report at Codecov.
|
Summary: * start adding tests * add return type and doc * adds tests * add no fill tests * add rgb test * check inplace * bug fix * bug fix * rewrite make grid * add plotting demos * rename file * remove * updt * Add viz * updt * update readme, add links * complte bounding boxes * Complete the examples! * link fix * link fixed Reviewed By: fmassa Differential Revision: D27433916 fbshipit-source-id: 144ca18f9d444b8c78141f2f7ae2f8077ab45076 Co-authored-by: Francisco Massa <[email protected]>
Fixes #3364 Fixes #3449.
Follow up of plotting utils #3330 #2785 #3296
I'm still not sure how we should handle single-channel images.