Added eps in the __repr__ of FrozenBN #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgfm
changed the title
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* feat: Updated FrozenBN eps to align with BatchNorm * feat: Added eps to __repr__ of FrozenBN * test: Updated unittest of __repr__ for FrozenBN * test: Updated unittest for eps value in BN and FrozenBN * fix: Revert FrozenBN eps value * test: Revert test on eps alignment between FrozenBN and BN
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* feat: Updated FrozenBN eps to align with BatchNorm * feat: Added eps to __repr__ of FrozenBN * test: Updated unittest of __repr__ for FrozenBN * test: Updated unittest for eps value in BN and FrozenBN * fix: Revert FrozenBN eps value * test: Revert test on eps alignment between FrozenBN and BN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
A few months back I suggested the PR #2190 that added the
epsattribute to FrozenBN. At that time, we set the default to 0 for backward compatibility. As per #2599, the silent difference of eps is an issue. So here is what this PR does:__repr__method to addsepsto align the method with the one oftorch.nn.BatchNorm2d__repr__Any suggestion is welcome!