[examples] adding the references for the new video API #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2770 +/- ##
==========================================
+ Coverage 73.15% 73.70% +0.55%
==========================================
Files 96 96
Lines 8396 8695 +299
Branches 1315 1408 +93
==========================================
+ Hits 6142 6409 +267
- Misses 1855 1877 +22
- Partials 399 409 +10
Continue to review full report at Codecov.
|
bjuncek
changed the title
fmassa
reviewed
Oct 8, 2020
examples/python/VideoAPI.ipynb
Outdated
| " # get random sample\n", | ||
| " path, target = random.choice(self.samples)\n", | ||
| " # get video object\n", | ||
| " vid = torch.classes.torchvision.Video(path, \"video\")\n", |
There was a problem hiding this comment.
nit: update to the final path of Video
examples/python/VideoAPI.ipynb
Outdated
| @@ -0,0 +1,672 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we change the name of the video to follow snake_case? None of the files in the repo (apart from from C++ files) use CamelCase
There was a problem hiding this comment.
do you mean the name of the file?
done if so
fmassa
approved these changes
Oct 8, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* gitignore now supports IPYNB aux files * Adding the reference ipython notebook * Update location * link fix * Add autodownload for colab * rename and address fmassa's comments * nitpicks * nitpicks * Apply suggestions from code review Co-authored-by: Francisco Massa <[email protected]>
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* gitignore now supports IPYNB aux files * Adding the reference ipython notebook * Update location * link fix * Add autodownload for colab * rename and address fmassa's comments * nitpicks * nitpicks * Apply suggestions from code review Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple IPYNB reference for using the new video API.