Fix fill parameter for PIL pad #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Jul 29, 2020
| @@ -261,8 +261,7 @@ def pad(img, padding, fill=0, padding_mode="constant"): | |||
| raise ValueError("Padding mode should be either constant, edge, reflect or symmetric") | |||
|
|
|||
| if padding_mode == "constant": | |||
| if isinstance(fill, numbers.Number): | |||
| fill = (fill,) * len(img.getbands()) | |||
| fill = _parse_fill(fill, img, "2.3.0")["fillcolor"] | |||
There was a problem hiding this comment.
I've traced back the min_version to python-pillow/Pillow@20b9d97, but you could probably go even further back. Still, I think its sufficient because I think a lot of the functionalities we are using require a higher version be default
Codecov Report
@@ Coverage Diff @@
## master #2515 +/- ##
==========================================
+ Coverage 70.60% 71.27% +0.67%
==========================================
Files 94 94
Lines 7995 8290 +295
Branches 1272 1395 +123
==========================================
+ Hits 5645 5909 +264
+ Misses 1947 1945 -2
- Partials 403 436 +33
Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* fix fill parameter for PIL pad * add test * fix * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2512