-
Notifications
You must be signed in to change notification settings - Fork 23.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Python2 and early Python3 leftovers #42919
Comments
Are python-enum and python-six third_party dependencies still needed? |
These should all be doable. python-enum/python-six should be droppable, but it looks like it came from nnpack so we would to make sure they've gone Python 3 only, or at least it's an optional dependency. |
Summary: See pytorch/pytorch#42919 Pull Request resolved: pytorch/pytorch#49785 Reviewed By: mruberry Differential Revision: D25963833 Pulled By: bugra fbshipit-source-id: 11c90d6b8d3f206c9d0a4d8621b773beb10c6ba2
Summary: See pytorch/pytorch#42919 Pull Request resolved: pytorch/pytorch#49785 Reviewed By: mruberry Differential Revision: D25963833 Pulled By: bugra fbshipit-source-id: 11c90d6b8d3f206c9d0a4d8621b773beb10c6ba2
Summary: See pytorch#42919 Pull Request resolved: pytorch#49785 Reviewed By: mruberry Differential Revision: D25963833 Pulled By: bugra fbshipit-source-id: 11c90d6b8d3f206c9d0a4d8621b773beb10c6ba2
Summary: See pytorch#42919 Pull Request resolved: pytorch#53349 Reviewed By: malfet Differential Revision: D27039089 Pulled By: bugra fbshipit-source-id: 8063dc184248604506a8dbb1bcb73da8ec85bb18
@ezyang It seems like a lot of legacy Python 2 code is in the caffe2 module. Are you still taking PRs for that section of the code even though it is deprecated? |
No, it's not worth it |
But PyTorch has built-in bool tensor since a long while
cc @ezyang
The text was updated successfully, but these errors were encountered: