Give preference to --never-returning-functions in inconsistent-return-statements check

[antoniogamizdelgado]

This fixes 2 bugs in the computation:

Never is handled in addition to NoReturn.
Give priority to the explicit --never-returning-functions option.

This PR was copied from #9535 (I cannot add commits there and we really need this).

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #7565

[Pierre-Sassoulas]

Hey thank you for taking over @antoniogamizbadger ! I feel like we lack some functional tests. (Shouldn't there be a Never used somewhere ?) That could be taken from the example in the original issue directly. Also the tests are not passing in the CI right now. When a message is expected in functional tests it's indicated with # [message-name] styile comment.

[DanielNoord]

@antoniogamizbadger Would you like to continue working on this?

[jacobtylerwalls]

@antoniogamizbadger Thanks for the contribution!

[jacobtylerwalls]

(Shouldn't there be a Never used somewhere ?)

This is covered by the call to assert_never(), which is annotated to return Never. Reverting that part of the patch causes a test failure, so it's covered.

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (d9ea2f7) to head (95b6e8b).
Report is 123 commits behind head on main.

Files with missing lines	Patch %	Lines
pylint/checkers/refactoring/refactoring_checker.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9591      +/-   ##
==========================================
- Coverage   95.80%   95.78%   -0.02%     
==========================================
  Files         174      174              
  Lines       18885    18880       -5     
==========================================
- Hits        18092    18085       -7     
- Misses        793      795       +2     

Files with missing lines	Coverage Δ
pylint/checkers/variables.py	97.23% <ø> (ø)
pylint/checkers/refactoring/refactoring_checker.py	98.16% <71.42%> (-0.22%)	⬇️

[jacobtylerwalls]

Coverage decrease is from moving existing uncovered lines around.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 95b6e8b