Add pull-through caching support for streaming metadata & multi-artifact content types #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gerrod3
force-pushed
the
pull-through-metadata-fetch
branch
2 times, most recently
from
b13fa9f to
2cefdf2
Compare
mdellweg
approved these changes
Jun 9, 2023
decko
reviewed
Jun 9, 2023
| content = c_type.objects.get(content.q()) | ||
| artifacts = content._artifacts | ||
| if artifact.sha256 != artifacts.get().sha256: | ||
| created_artifact_digests = {rp: a.sha256 for rp, a in artifacts.items() if a} |
There was a problem hiding this comment.
rp and a are relative path and artifact respectively?
decko
approved these changes
Jun 9, 2023
gerrod3
force-pushed
the
pull-through-metadata-fetch
branch
from
2cefdf2 to
8aa3428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3817
fixes: #3818
TODO: