Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaRegistrySerde: Avro deserialization via topic name #4521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

1-alex98
Copy link

@1-alex98 1-alex98 commented Mar 4, 2025

Avro deserialization without magic byte using lookup by topic name as fallback like in serialization Closes #4520

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@1-alex98 1-alex98 requested a review from a team as a code owner March 4, 2025 12:23
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there 1-alex98! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@1-alex98
Copy link
Author

1-alex98 commented Mar 4, 2025

Sonar is happy -> Where can I view that?

Avro deserialization without magic byte using lookup by topic name as fallback like in serialization
Closes provectus#4520
@1-alex98 1-alex98 force-pushed the feature/#4520-SchemaRegistrySerde-Avro-deserialization branch from 678cb96 to ca7aaff Compare March 4, 2025 12:28
@1-alex98
Copy link
Author

1-alex98 commented Mar 4, 2025

The Pipeline failing seems to be unrelated to the PR

@1-alex98 1-alex98 requested a review from a team as a code owner March 4, 2025 13:01
@Haarolean
Copy link
Contributor

@1-alex98 hey, this repo is not maintained (#4255). Could you raise the PR at https://github.com/kafbat/kafka-ui instead?

@1-alex98
Copy link
Author

1-alex98 commented Mar 6, 2025

Why not write that into the readme or pin an issue that says something like that or archieve the repo? @Haarolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants