-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] Add interval field for default dashboards #5405
Conversation
…ards Signed-off-by: Ethan Dean <[email protected]>
Looks quite good to me |
Signed-off-by: Quentin Bisson <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
Signed-off-by: Quentin Bisson <[email protected]> Signed-off-by: QuentinBisson <[email protected]>
Can you please fix the linting? |
hyper theoretically, Using |
Signed-off-by: Ethan Dean <[email protected]>
@ecd0011 would you be able to do the same for the |
@jkroepke It seems like they're serving different purposes.
In other words, @QuentinBisson given the documentation @jkroepke sent recommends to use the |
thanks for clarifications! Absolute right. I thought the PR is doing something like
|
What this PR does / why we need it
This PR adds support for configuring the interval value used in Grafana dashboards through a new Helm value
grafana.defaultDashboardsInterval
.Many Grafana dashboards in the chart have hardcoded
"interval": "1m"
values, which limits the resolution of metrics displayed regardless of your Prometheus scrape interval. If you're using a lower scrape interval (like 10s or 30s), you're missing out on higher resolution data that's already being collected.This allows you to configure by making the interval configurable via Helm values, similar to how dashboard editability is already handled using the
sync_grafana_dashboards.py
script.Checklist
[prometheus-couchdb-exporter]
)