Make ServerClusterInterface return multiple paths for handling instead of just one #37931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Mar 7, 2025
|
PR #37931: Size comparison from 36a1bbd to 89d349e Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37931: Size comparison from 36a1bbd to 54466ed Full report (3 builds for cc32xx, stm32)
|
andy31415
changed the title
|
PR #37931: Size comparison from 36a1bbd to 20a4370 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Mar 8, 2025
Comment on lines
-132
to
-133
| /// Unregister all registrations for the given endpoint. | ||
| void UnregisterAllFromEndpoint(EndpointId endpointId); |
There was a problem hiding this comment.
OK, so what's supposed to happen when an endpoint is removed? How is that supposed to work?
|
PR #37931: Size comparison from 36a1bbd to f3eaece Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37931: Size comparison from 36a1bbd to ba9bc41 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37928 : server cluster interfaces now can have
pathsinstead of a single path.This also removes the
UnregisterAllFromEndpointinterface as it may result in unexpected behavior. TheServerClustersimplementation is also slightly more awkward (but still works).Testing
Unit tests updated and added