[WIP] Generate ConcentrationMeasurement cluster with Alchemy #37930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37930: Size comparison from 36a1bbd to 0a28542 Full report (3 builds for cc32xx, stm32)
|
| <attribute side="server" code="0x0000" name="MeasuredValue" define="MEASURED_VALUE" type="single" isNullable="true" optional="true"> | ||
| <description>MeasuredValue</description> |
There was a problem hiding this comment.
This seems like an alchemy issue, but why do we have both "name" and "description" bits here?
| <mandatoryConform> | ||
| <feature name="MEA"/> | ||
| </mandatoryConform> | ||
| </attribute> | ||
| <attribute side="server" code="0x0009" name="MeasurementMedium" define="MEASUREMENT_MEDIUM" type="MeasurementMediumEnum" min="0" max="2" optional="true"> |
There was a problem hiding this comment.
I'm not sure why this was set to optional before. It seems this is mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37391
Generate ConcentrationMeasurement cluster using Alchemy.
Testing
Ran Unit tests and CI checks with Python and YAML tests (PENDING)