Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nix installation instructions #331

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

flexxyfluxx
Copy link
Contributor

see #330

@flexxyfluxx flexxyfluxx changed the title #330 Update Nix installation instructions Update Nix installation instructions Jan 8, 2025
@printfn
Copy link
Owner

printfn commented Jan 8, 2025

Thanks for the suggestion. I guess it makes sense not to recommend nix-env, but I do wonder if maybe we can make it a bit shorter. I feel like people using nix would already know how to install packages on their system, so maybe we could just say it's in nixpkgs, or maybe provide the nix-shell command?

@flexxyfluxx
Copy link
Contributor Author

You're right, it is long. The bit about why nix-env is bad is probably also unnecessary, those who would possibly be benefitted by having access to that definitely don't need telling it exists.

@flexxyfluxx
Copy link
Contributor Author

i've shortened it, lmk what you think. seems to fit on a single line now (at least in a browser, on a desktop)

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (b838c78) to head (96c47d4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          52       52           
  Lines       14364    14364           
=======================================
  Hits        11863    11863           
  Misses       2501     2501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flexxyfluxx flexxyfluxx marked this pull request as draft January 8, 2025 22:20
@printfn
Copy link
Owner

printfn commented Jan 9, 2025

Thanks, looks good!

@flexxyfluxx flexxyfluxx marked this pull request as ready for review January 10, 2025 16:18
@flexxyfluxx
Copy link
Contributor Author

At last, I have found the button to open this PR back up.

@printfn printfn merged commit 2151317 into printfn:main Jan 14, 2025
7 checks passed
@flexxyfluxx flexxyfluxx deleted the patch-1 branch January 16, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants