Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles in all examples #223

Closed
wangjiawen2013 opened this issue Aug 12, 2024 · 1 comment · Fixed by #233
Closed

Titles in all examples #223

wangjiawen2013 opened this issue Aug 12, 2024 · 1 comment · Fixed by #233
Assignees
Labels
good first issue Good for newcomers

Comments

@wangjiawen2013
Copy link

wangjiawen2013 commented Aug 12, 2024

Hi,
I cannot run some of the example code in plotly.rs.book. I find all the .title(Title::new("balabala") should be adjusted to .title(Title::with_text("balabala") in order to run the examples successfully.
Besides, .side(Side::Right), must be adjusted to .side(AxisSide::Right), too.

@andrei-ng
Copy link
Collaborator

Hi @wangjiawen2013 . Good catch!
Indeed, latest release has changed the API to allow passing all sorts of strings to title(s). We've missed the examples in the book.

@andrei-ng andrei-ng added the good first issue Good for newcomers label Aug 12, 2024
@andrei-ng andrei-ng self-assigned this Aug 26, 2024
andrei-ng added a commit that referenced this issue Sep 6, 2024
Closes #223

Signed-off-by: Andrei Gherghescu <[email protected]>
andrei-ng added a commit that referenced this issue Sep 6, 2024
Closes #223

Signed-off-by: Andrei Gherghescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants