-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Play 3 and Pekko #490
Conversation
@ihostage What do you think about the ALPN thing? Funny or not? |
It was a predictable 😂 |
@ihostage You want to open an issue? |
Pushed a commit to see if CI turns green ignoring the ALPN problem. |
I want an open PR, because It will be more quickly win strategy for us 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
71abc1b
to
7fab605
Compare
Let's merge this so we can continue, we can enable the tests in another PR. |
The funny thing is
is not ported to Pekko gRPC yet 🤣 so we end up with the
IllegalArgumentException: "ALPN must be enabled and list HTTP/2 as a supported protocol"
here as well.For this PR good news is that if we would comment out
play-grpc/play-specs2/src/test/scala/play/grpc/specs2/PlaySpecs2Spec.scala
Lines 67 to 72 in deeea2e
play-grpc/play-scalatest/src/test/scala/play/grpc/scalatest/PlayScalaTestSpec.scala
Lines 65 to 68 in deeea2e
play-grpc/play-scalatest/src/test/scala/play/grpc/scalatest/PlayActionsScalaTestSpec.scala
Lines 67 to 70 in deeea2e
play-grpc/play-testkit/src/test/java/play/grpc/testkit/PlayJavaFunctionalTest.java
Lines 84 to 101 in deeea2e
it should become green.
This PR also switched groupId to
org.playframework
.TODO:
docs/
folder