Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework merging DB connection configuration #214

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

pkosiec
Copy link
Owner

@pkosiec pkosiec commented Dec 9, 2023

@pkosiec pkosiec added 🐛 bug Label used for changelog generation from PRs 🚀 enhancement New feature or request labels Dec 9, 2023
@pkosiec pkosiec force-pushed the rework-merging-db-config branch from e043138 to a783d86 Compare December 9, 2023 10:57
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #214 (e3dc6ae) into main (b9a1542) will decrease coverage by 1.54%.
The diff coverage is 84.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   92.80%   91.27%   -1.54%     
==========================================
  Files          18       17       -1     
  Lines         278      298      +20     
  Branches       56       62       +6     
==========================================
+ Hits          258      272      +14     
- Misses         12       17       +5     
- Partials        8        9       +1     
Flag Coverage Δ
cli 93.75% <ø> (ø)
core 90.59% <84.00%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/src/options.ts 92.15% <ø> (ø)
core/src/database/database-connector.ts 100.00% <100.00%> (ø)
core/src/database/index.ts 100.00% <ø> (ø)
core/src/database/database.ts 87.80% <90.47%> (+2.80%) ⬆️
core/src/config.ts 81.57% <76.00%> (-12.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a1542...e3dc6ae. Read the comment docs.

@pkosiec pkosiec force-pushed the rework-merging-db-config branch from a783d86 to e3dc6ae Compare December 9, 2023 11:03
@pkosiec pkosiec merged commit 256212f into main Dec 9, 2023
@pkosiec pkosiec deleted the rework-merging-db-config branch December 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Label used for changelog generation from PRs 🚀 enhancement New feature or request
Projects
None yet
1 participant