Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: update pd-client to fix the resource limiter issue #54898

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 25, 2024

What problem does this PR solve?

Issue Number: ref #47421 ref tikv/pd#8435

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 25, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 25, 2024
@nolouch
Copy link
Member Author

nolouch commented Jul 25, 2024

/retest-required

2 similar comments
@nolouch
Copy link
Member Author

nolouch commented Jul 25, 2024

/retest-required

@nolouch
Copy link
Member Author

nolouch commented Jul 25, 2024

/retest-required

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3854%. Comparing base (6854e60) to head (a1245e7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54898         +/-   ##
=================================================
- Coverage   72.7922%   56.3854%   -16.4069%     
=================================================
  Files          1558       1680        +122     
  Lines        438460     615340     +176880     
=================================================
+ Hits         319165     346962      +27797     
- Misses        99633     245131     +145498     
- Partials      19662      23247       +3585     
Flag Coverage Δ
integration 37.2993% <ø> (?)
unit 72.2708% <ø> (+0.4685%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6020% <ø> (+6.7365%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 25, 2024
Copy link

ti-chi-bot bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 25, 2024
Copy link

ti-chi-bot bot commented Jul 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-25 06:17:56.141387698 +0000 UTC m=+1112298.132329160: ☑️ agreed by glorv.
  • 2024-07-25 07:26:10.84298887 +0000 UTC m=+1116392.833930336: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit d12f841 into pingcap:master Jul 25, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #54910.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54911.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #54912.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 25, 2024
@nolouch nolouch deleted the update-pd-client branch July 26, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants