refactor: Introduce type hinting in Connection class #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkobrenters
approved these changes
Oct 30, 2023
|
Thanks @DannyvdSluijs. I think this is very welcome. It doesn't have to be one big bang commit, unless someone want to put in the effort all at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort / discovery to see if this library could be improved with the PHP Type Hints. This is adding them to the
Connectionclass where the type was very clear. There are still a lot of mixed and missing types but I don't want to introduce any breakage beyond what the docblocks already pointed out.I'm curious about your opinions and remarks to see if we should move this forward and if so in which way (small increments or one big bang commit).