Fix GMagick No encode delegate #747
Conversation
mlocati
force-pushed
the
gmagick-no-encode-delegate-v2
branch
4 times, most recently
from
d8909c4 to
76322df
Compare
|
If I remember correctly from #733 the error didn’t always show up. It seems that this issue only occurs before the first successful save operation for this format happened. Maybe adding |
Yep, it worked! And also broke PHP with a segfault 🤣 |
| @@ -597,6 +597,26 @@ public function testInOutResult($file, $in, $out) | |||
| $thumb->save($filename); | |||
| } | |||
|
|
|||
| /** | |||
| * @dataProvider inOutResultProvider | |||
| * @runInSeparateProcess | |||
There was a problem hiding this comment.
| * @runInSeparateProcess | |
| * @runInSeparateProcess | |
| * @preserveGlobalState disabled |
Maybe this helps with the PHP segfault.
mlocati
force-pushed
the
gmagick-no-encode-delegate-v2
branch
11 times, most recently
from
ce6708f to
5c6a33d
Compare
mlocati
force-pushed
the
gmagick-no-encode-delegate-v2
branch
from
5c6a33d to
be89a3c
Compare
|
Any suggestion to fix those |
|
I tried with c7dfccd#diff-4c0aab9c8ed7ce313e9c5822412ee5e575471f32232b34724e15b2072771b2c3 and in this case there's no segfault, so the issue is with PHPUnit (see https://travis-ci.com/github/avalanche123/Imagine/builds/198035883) |
mlocati
force-pushed
the
gmagick-no-encode-delegate-v2
branch
from
c7dfccd to
6a9d24c
Compare
|
Maybe we should fix the issue without having it captured by the CI for now? |
|
I guess it's the only solution... do you mind submitting a new pull request with only the fix? |
|
Done: #750 |
No description provided.