-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embedder.exe fails when USER_DIR in config.h is defined #191
Comments
Yes I can reproduce this issue with latest git.
|
And I can confirm the fix works.
|
However, Zadig will often crash with the above configuration, probably due to the embedded Cypress USB driver. |
I just tried with one build which remove WinUSB/libusbk/libusb-win32 but only with Cypress, with or without the changes, Zadig will crash. So I guess I do not know how to use the option of user defined driver yet. IMHO this is not well documented.
|
It seems to me I need to do something to create a template inf and cat file but it is a bit more complicated than that. |
It seems to me this is not a real issue but rather lack of documentation to use the custom driver file. I was trying to embed cyusb3 but failed. |
One simple solution is to use dpscat.exe from libusbk to sign a custom driver package, then you can use Windows Device Manager to install the file. Windows 10 will pop up a warning message but the installation will be successful. dpscat is part of libusbk and it uses part of the libwdi codes. Example run log:
Better method: Use dpinst32.exe/dpinst64.exe from a libusbK driver package and copy dpinst.xml into your driver folder as well. Then you can run dpinst32/dpinst64 to install the driver package for 32bit/64bit respectively.
|
From Travis -- but I have not tried it yet.
|
In reality, once you use the dpscat to build the driver package, you can use different method to create the driver installer, not necessary to follow the above libusbk method or the method in libwdi Zadig or libwdi wid-simple example. |
* With thanks to JSB2500 for the fix suggestion * Closes pbatard#191 * Also fix a CodeQL reported issue
Version: v1.3.1
When USER_DIR in config.h is defined, embedded.exe reports this error: "EMBED C:...\libwdi\libwdi\libusb0.dll embedder : error: Could not open file 'C:...\libwdi\libwdi\libusb0.dll'."
Suggested fix: Change line 298 of embedder.c from:
embeddable[i].reuse_last = 0;
to:
embeddable[i].reuse_last = embeddable_fixed[i].reuse_last;
The text was updated successfully, but these errors were encountered: