This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add Statemine as parachain 1000 to rococo trusted teleporters #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
A0-please_review
|
I'm confused, why would you need Statemine on Rococo when you already have Rockmine? Wouldn't it be better if you just moved Rockmine to 1000? |
Rockmine was never added. Some context here -> paritytech/cumulus#684 |
|
Okay, does it make more sense to just remove the Rockmine config here then? No reason to keep two assets parachains in Rococo right? |
Sounds reasonable to me. |
|
Makes the migration a little harder, but I can remove it, sure. |
bkchr
approved these changes
Nov 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a weird historical thing where Statemint-like chains are at id 1001 on Rococo (and thus you cannot teleport funds to Statemint if it is registered at id 1000).
We can remove 1001 later if we want.