Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Logging & metrics improvements #4184

Closed
wants to merge 4 commits into from
Closed

Logging & metrics improvements #4184

wants to merge 4 commits into from

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Oct 30, 2021 •
edited
Loading

  • Add an extra backing log
  • Fixes dispute concluding metrics (they previously only fired when a dispute concluded at the same time it opened which is never)
  • Remove broken dispute distribution failure logs & downgrade to trace - we can re-enable when there's a sensible non-noisy log

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 30, 2021
drahnr
drahnr approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lldenaurois Lldenaurois mentioned this pull request Nov 20, 2021
Merged
@ordian ordian closed this Nov 20, 2021
@ordian ordian deleted the rh-improve-logging branch November 20, 2021 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@Lldenaurois Lldenaurois Lldenaurois approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rphmeier @drahnr @Lldenaurois @ordian