Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/litep2p: Bring the latest compatibility fixes via v0.9.1 #7640

Merged
merged 9 commits into from
Feb 20, 2025

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Feb 20, 2025

This PR updates litep2p to version 0.9.1. The yamux config is entirely removed to mirror the libp2p yamux upstream version.
While at it, I had to bump indexmap and URL as well.

[0.9.1] - 2025-01-19

This release enhances compatibility between litep2p and libp2p by using the latest Yamux upstream version. Additionally, it includes various improvements and fixes to boost the stability and performance of the WebSocket stream and the multistream-select protocol.

Changed

  • yamux: Switch to upstream implementation while keeping the controller API (#320)
  • req-resp: Replace SubstreamSet with FuturesStream (#321)
  • cargo: Bring up to date multiple dependencies (#324)
  • build(deps): bump hickory-proto from 0.24.1 to 0.24.3 (#323)
  • build(deps): bump openssl from 0.10.66 to 0.10.70 (#322)

Fixed

  • websocket/stream: Fix unexpected EOF on Poll::Pending state poisoning (#327)
  • websocket/stream: Avoid memory allocations on flushing (#325)
  • multistream-select: Enforce io::error instead of empty protocols (#318)
  • multistream: Do not wait for negotiation in poll_close (#319)

cc @paritytech/networking

Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv added the T0-node This PR/Issue is related to the topic “node”. label Feb 20, 2025
@lexnv lexnv self-assigned this Feb 20, 2025
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv requested review from dmitry-markin, a team and alexggh February 20, 2025 12:58
@lexnv lexnv enabled auto-merge February 20, 2025 13:29
@lexnv lexnv added the A4-needs-backport Pull request must be backported to all maintained releases. label Feb 20, 2025
@lexnv lexnv added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit 42e9de7 Feb 20, 2025
258 of 271 checks passed
@lexnv lexnv deleted the lexnv/release-0.9.1 branch February 20, 2025 14:26
@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7640-to-stable2407
git worktree add --checkout .worktree/backport-7640-to-stable2407 backport-7640-to-stable2407
cd .worktree/backport-7640-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 42e9de7f4fdb191cd531b443c68cfe19886ec311
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7640-to-stable2409
git worktree add --checkout .worktree/backport-7640-to-stable2409 backport-7640-to-stable2409
cd .worktree/backport-7640-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 42e9de7f4fdb191cd531b443c68cfe19886ec311
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7640-to-stable2412
git worktree add --checkout .worktree/backport-7640-to-stable2412 backport-7640-to-stable2412
cd .worktree/backport-7640-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 42e9de7f4fdb191cd531b443c68cfe19886ec311
git push --force-with-lease

github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
This PR updates litep2p to version 0.9.1. The yamux config is entirely
removed to mirror the libp2p yamux upstream version.
While at it, I had to bump indexmap and URL as well.

## [0.9.1] - 2025-01-19

This release enhances compatibility between litep2p and libp2p by using
the latest Yamux upstream version. Additionally, it includes various
improvements and fixes to boost the stability and performance of the
WebSocket stream and the multistream-select protocol.

### Changed

- yamux: Switch to upstream implementation while keeping the controller
API ([#320](paritytech/litep2p#320))
- req-resp: Replace SubstreamSet with FuturesStream
([#321](paritytech/litep2p#321))
- cargo: Bring up to date multiple dependencies
([#324](paritytech/litep2p#324))
- build(deps): bump hickory-proto from 0.24.1 to 0.24.3
([#323](paritytech/litep2p#323))
- build(deps): bump openssl from 0.10.66 to 0.10.70
([#322](paritytech/litep2p#322))

### Fixed

- websocket/stream: Fix unexpected EOF on `Poll::Pending` state
poisoning ([#327](paritytech/litep2p#327))
- websocket/stream: Avoid memory allocations on flushing
([#325](paritytech/litep2p#325))
- multistream-select: Enforce `io::error` instead of empty protocols
([#318](paritytech/litep2p#318))
- multistream: Do not wait for negotiation in poll_close
([#319](paritytech/litep2p#319))

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <[email protected]>
(cherry picked from commit 42e9de7)
@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Successfully created backport PR for stable2503:

EgorPopelyaev pushed a commit that referenced this pull request Feb 20, 2025
… v0.9.1 #7640  (#7647)

Backport #7640 into `stable2412` from lexnv.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request Feb 25, 2025
Backport #7640 into `stable2503` from lexnv.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Alexandru Vasile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants