Implement DecodeWithMemTracking for some structs #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
force-pushed
the
decode-with-mem-tracking
branch
2 times, most recently
from
0a2c319 to
559183c
Compare
serban300
changed the title
niklasad1
reviewed
Jan 29, 2025
There was a problem hiding this comment.
You need to bump the MSRV to v1.79.0 and change the rustc version to v1.79.0 in the CI here: https://github.com/paritytech/parity-common/blob/master/.github/workflows/ci.yml#L42
serban300
force-pushed
the
decode-with-mem-tracking
branch
from
559183c to
4c854ff
Compare
serban300
force-pushed
the
decode-with-mem-tracking
branch
from
4c854ff to
17fee98
Compare
niklasad1
approved these changes
Jan 29, 2025
Thank you for the suggestion ! This seems to fix the CI errors. I will wait 1-2 more days before merginf the PR, just to make sure we don't get any bug report for |
bkchr
approved these changes
Jan 29, 2025
ordian
approved these changes
Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
DecodeWithMemTrackingfor:uintand fixed hashesBoundedVecandWeakBoundedVec