Skip to content
This repository was archived by the owner on Sep 24, 2020. It is now read-only.

[Bug] Unused variable when used in string literal as method argument #280

Closed
kilgaloon opened this issue Dec 7, 2016 · 5 comments
Closed

[Bug] Unused variable when used in string literal as method argument #280

kilgaloon opened this issue Dec 7, 2016 · 5 comments
Labels
bug compiler

Comments

@kilgaloon
Copy link
Contributor

So basically this:

$name="John Doe";
Class::method("Hello $name");

This throws warning that variable is unused, but clearly it is.
@kilgaloon kilgaloon mentioned this issue Dec 7, 2016
Open
@ovr
Copy link
Owner

ovr commented Dec 8, 2016

This bug is caused because We didn't support template strings...

@kilgaloon
Copy link
Contributor Author

It would be nice to have it then.

ovr added a commit that referenced this issue Dec 8, 2016
@ovr
[Compiler] Initial implementation for Node\Scalar\Encapsed (refs #280)
795841b
@ovr
Copy link
Owner

ovr commented Dec 8, 2016

@kilgaloon looks like you case was fixed, can you try latest master changes?
Thanks

@kilgaloon
Copy link
Contributor Author

Ye, you can close this issue

@ovr
Copy link
Owner

ovr commented Dec 8, 2016 •
edited
Loading

@kilgaloon Thank for bug reporting and testing 👍
Going to close this issue because fixed in 795841b

Thanks

@ovr ovr closed this as completed Dec 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ovr @kilgaloon