Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fs.mkdir regression #16497

Merged
merged 12 commits into from
Jan 20, 2025
Merged

fix fs.mkdir regression #16497

merged 12 commits into from
Jan 20, 2025

Conversation

dylan-conway
Copy link
Member

What does this PR do?

Fixes recursive: true throwing when the directory already exists

closes #16474

How did you verify your code works?

Added a regression test

@robobun
Copy link

robobun commented Jan 18, 2025

Updated 4:10 PM PT - Jan 19th, 2025

@dylan-conway, your commit e0bec8a has 1 failures in #10114:


🧪   try this PR locally:

bunx bun-pr 16497

paperclover
paperclover previously approved these changes Jan 18, 2025
@paperclover paperclover enabled auto-merge January 18, 2025 07:46
@okineadev
Copy link
Contributor

🧪   try this PR locally:

bunx bun-pr 16497

I tested this build, it fixed my issue which I wrote in #16474 (comment) 👍

@okineadev
Copy link
Contributor

And another question, will you release a hotfix with this fix?

@RiskyMH RiskyMH disabled auto-merge January 18, 2025 15:29
@RiskyMH

This comment has been minimized.

@Jarred-Sumner
Copy link
Collaborator

This will be in Bun v1.1.46 which releases today (once the tests are fixed)

@dylan-conway dylan-conway merged commit 3128bee into main Jan 20, 2025
66 of 69 checks passed
@dylan-conway dylan-conway deleted the dylan/fix-mkdir branch January 20, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.mkdirSync() throws when the path already exists with recursive:true
6 participants