8351431: Type annotations on new class creation expressions can't be retrieved

[cushon]

Hello,

Please consider this fix for JDK-8351431, which allows type annotations on the class type of a new class creation expression to be retrieved by the Compiler Tree API.

Currently Attr is skipping annotateTypeSecondStage for all new class types, but the special case only needs to be applied to anonymous new class creation expressions to be consistent with logic in Annotate:

jdk/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Annotate.java

Lines 1162 to 1166 in 7c22b81

	if (tree.def == null) {
	scan(tree.clazz);
	}
	scan(tree.args);
	// the anonymous class instantiation if any will be visited separately.

This also removes a check of isNewClass (now isNewAnonymousClass) in InvalidCanonicalConstructorInRecord, because the field was only set before descending into a JCNewClass.clazz, which can't contain return statements.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351431: Type annotations on new class creation expressions can't be retrieved (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23946/head:pull/23946
$ git checkout pull/23946

Update a local copy of the PR:
$ git checkout pull/23946
$ git pull https://git.openjdk.org/jdk.git pull/23946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23946

View PR using the GUI difftool:
$ git pr show -t 23946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23946.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (84d34fd2)