Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC API 18-062 markup corrections #254

Closed
wants to merge 22 commits into from

Conversation

anermina
Copy link

Markup corrections made in accordance to metanorma#9 and metanorma#10.

@manuelfuenmayor
Copy link
Contributor

@anermina, in regard to the commit: bc7c6a3
This was a markup convention agreed with Nick in the comment: metanorma#2 (comment)
That's why I encoded it on that way.
Now, to be honest, I find more sense in the way that you edited the abstract test.

@anermina
Copy link
Author

Thanks for letting me know, @manuel489 !
I will ask Nick for his opinion on this.

@ronaldtse
Copy link
Contributor

@anermina can you make the PR to the metanorma fork instead of this one? We have to complete our copy before making a PR here. Thanks.

@ronaldtse ronaldtse force-pushed the 18-062_markup-corr branch 3 times, most recently from 8261ea1 to 0448084 Compare September 30, 2021 09:51
- Metanorma format: remove non-semantic concerns, use dynamic features not hard-coded links
- Add external-id
- Correct markup in clauses
- Fix markup in abstract tests
@ronaldtse
Copy link
Contributor

This is all merged in https://github.com/metanorma/ogcapi-processes/

@ronaldtse
Copy link
Contributor

@anermina can you please help close this after vacation? Thanks!

@ronaldtse
Copy link
Contributor

NOTE: This PR is stale -- DO NOT MERGE THIS ONE. Thanks.

@anermina anermina closed this Oct 21, 2021
@ronaldtse ronaldtse deleted the 18-062_markup-corr branch October 22, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants