-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support DSDL Dataset #2925
Conversation
wufan-tb
commented
Apr 19, 2023
- support dsdl seg dataset
- add dsdl dataset citest
- validated accuracy on voc2012 and cityscapes
configs/dsdl/cityscapes.py
Outdated
train_ann = 'dsdl/set-train/train.yaml' | ||
val_ann = 'dsdl/set-val/val.yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create the dsdl
folder at mmsegmentation root path or at the datasets root path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this path will concate with root_path, so the actually path is "data/cityscapes/dsdl/set-train/train.yaml".
furthermore, here is a typical example of dsdl dataset's file struct :
data
└── VOC12-seg
├── dsdl
└── original
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since users may not know how to use this dataset interface, could you write a document to introduce how to generate the train.yaml
and val.yaml
, or provide an example?
configs/dsdl/voc.py
Outdated
# dataset settings | ||
dataset_type = 'DSDLSegDataset' | ||
data_root = 'data/VOC12-seg' | ||
img_prefix = 'original' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 'original' a keyword needed inside DSDL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, users should change it by actual path. (or no img_prefix, decied by it's file sturct)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended not to use original
and try to be consistent with https://github.com/open-mmlab/mmsegmentation/blob/main/configs/_base_/datasets/pascal_voc12_aug.py#L47, since other users may not notice this detail.
configs/dsdl/cityscapes.py
Outdated
train_ann = 'dsdl/set-train/train.yaml' | ||
val_ann = 'dsdl/set-val/val.yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since users may not know how to use this dataset interface, could you write a document to introduce how to generate the train.yaml
and val.yaml
, or provide an example?
configs/dsdl/voc.py
Outdated
# dataset settings | ||
dataset_type = 'DSDLSegDataset' | ||
data_root = 'data/VOC12-seg' | ||
img_prefix = 'original' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended not to use original
and try to be consistent with https://github.com/open-mmlab/mmsegmentation/blob/main/configs/_base_/datasets/pascal_voc12_aug.py#L47, since other users may not notice this detail.
9d7876c
to
8920dd4
Compare
- support dsdl seg dataset - add dsdl dataset citest - validated accuracy on voc2012 and cityscapes