[Feature] Support auto import modules from registry. #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.25% // Head: 83.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2481 +/- ##
===========================================
+ Coverage 83.25% 83.37% +0.11%
===========================================
Files 145 146 +1
Lines 8505 8522 +17
Branches 1273 1275 +2
===========================================
+ Hits 7081 7105 +24
+ Misses 1213 1202 -11
- Partials 211 215 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MeowZheng
reviewed
Feb 1, 2023
MeowZheng
reviewed
Feb 1, 2023
mmseg/registry/registry.py
Outdated
| @@ -32,52 +32,90 @@ | |||
| from mmengine.registry import Registry | |||
|
|
|||
| # manage all kinds of runners like `EpochBasedRunner` and `IterBasedRunner` | |||
| RUNNERS = Registry('runner', parent=MMENGINE_RUNNERS) | |||
| RUNNERS = Registry( | |||
| 'runner', parent=MMENGINE_RUNNERS, locations=['mmseg.engine.runner']) | |||
There was a problem hiding this comment.
there is no mmseg.engine.runner in mmseg?
MeowZheng
reviewed
Feb 2, 2023
Comment on lines
-34
to
-40
| from mmseg.utils import register_all_modules | ||
|
|
||
| config_path = 'configs/pspnet/pspnet_r50-d8_4xb2-40k_cityscapes-512x1024.py' | ||
| checkpoint_path = 'checkpoints/pspnet_r50-d8_512x1024_40k_cityscapes_20200605_003338-2966598c.pth' | ||
|
|
||
| # register all modules in mmseg into the registries | ||
| register_all_modules() |
There was a problem hiding this comment.
I think without register_all_modules it needs to add init_default_scope
mmseg/registry/registry.py
Outdated
Comment on lines
35
to
40
| RUNNERS = Registry('runner', parent=MMENGINE_RUNNERS) | ||
| # manage runner constructors that define how to initialize runners | ||
| RUNNER_CONSTRUCTORS = Registry( | ||
| 'runner constructor', parent=MMENGINE_RUNNER_CONSTRUCTORS) | ||
| # manage all kinds of loops like `EpochBasedTrainLoop` | ||
| LOOPS = Registry('loop', parent=MMENGINE_LOOPS) |
There was a problem hiding this comment.
we should keep these registries in mmseg
MeowZheng
reviewed
Feb 23, 2023
demo/image_demo.py
Outdated
| @@ -24,7 +24,7 @@ def main(): | |||
| '--title', default='result', help='The image identifier.') | |||
| args = parser.parse_args() | |||
|
|
|||
| register_all_modules() | |||
| init_default_scope('mmseg') | |||
There was a problem hiding this comment.
init_model have add init_default_scope('mmseg'), so there is no need to add it
MeowZheng
reviewed
Feb 23, 2023
demo/inference_demo.ipynb
Outdated
| "from mmseg.utils import register_all_modules\n", | ||
| "register_all_modules()" | ||
| "\n", | ||
| "init_default_scope('mmseg')" |
MeowZheng
reviewed
Feb 23, 2023
docs/en/user_guides/3_inference.md
Outdated
| from mmseg.apis import init_model | ||
| from mmseg.utils import register_all_modules | ||
|
|
||
| init_default_scope('mmseg') |
There was a problem hiding this comment.
I think init_default_scope can be removed
MeowZheng
approved these changes
Feb 23, 2023
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* Fix tensorboard tracking with `accelerate` @ `main` * Fix `train_unconditional.py` with accelerate from main.
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
## Motivation The registry now supports auto-import modules from the given location. register_all_modules before running is no longer needed. The modules will be lazy-imported during building. - [x] This PR can be merged after open-mmlab/mmengine#643. The MMEngine version should be updated. Ref: open-mmlab/mmdetection#9143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The registry now supports auto-import modules from the given location.
register_all_modules before running is no longer needed. The modules will be lazy-imported during building.
Ref: open-mmlab/mmdetection#9143