Fix invalid routes(ipv6) added to upf module

[sureshmarikkannu]

No description provided.

[gab-arrobo]

If the MAC for next hop is not already stored, then it will try to probe it using self._probe_addr and everything works as expected because self._probe_addr only tries IPv4 addresses. The issue will show up only if the MAC for the next hop is already stored. So, what I would recommend is to move validate_ipv4 from _probe_addr to add_new_route_entry. What do you think?

     def _probe_addr(self, route_entry: RouteEntry) -> None:
         """Probes the MAC address of a neighbor.
         Pings the neighbor to trigger the update of the ARP table.

         Args:
            route_entry (NeighborEntry): The neighbor entry.
         """
         self._unresolved_arp_queries_cache[route_entry.next_hop_ip] = route_entry
         logger.info("Adding entry %s in arp table by pinging", route_entry)
-        if not validate_ipv4(route_entry.next_hop_ip):
-            return
         send_ping(route_entry.next_hop_ip)

     def _get_gate_idx(self, route_entry: RouteEntry, module_name: str) -> int:

To here:

Suggested change

	if not type(ipaddress.ip_address(route_entry.next_hop_ip)) is ipaddress.IPv4Address:
	return
	if not validate_ipv4(route_entry.next_hop_ip):
	return

[sureshmarikkannu]

done

[gab-arrobo]

+1