Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised the dataplane to introduce "access" & "core" #114

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

ajamshed
Copy link
Contributor

Updated both pfcpiface and zmq-cpiface controllers.

@ajamshed ajamshed requested a review from krsna1729 July 31, 2020 22:47
@@ -29,7 +29,7 @@ type sessRecord struct {

var sessions map[uint64]sessRecord

func pfcpifaceMainLoop(upf *upf, n3ip string, sourceIP string) {
func pfcpifaceMainLoop(upf *upf, accessip string, sourceIP string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessIP?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other places too. Also do we have to advertise our coreIP as well during association setup so that SMF knows for N9 interfacing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about the N9 interface soon.

@ajamshed ajamshed force-pushed the topics/rename_modules branch 2 times, most recently from 922d774 to 55ff5e1 Compare August 2, 2020 05:19
Comment on lines 112 to +115
except KeyError:
self.s1u_ifname = "s1u"
self.sgi_ifname = "sgi"
print('Can\'t parse interface name(s)! Setting it to default values ({}, {})'.format("s1u", "sgi"))
self.access_ifname = "access"
self.core_ifname = "core"
print('Can\'t parse interface name(s)! Setting it to default values ({}, {})'.format("access", "core"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this behavior is consistent across the other two controllers as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work fine. I tested it with sim mode as well. It is working fine. Zmq-based controller should work fine as well. I tested it with Spirent.

krsna1729
krsna1729 previously approved these changes Aug 2, 2020
@krsna1729
Copy link
Member

@yoooou there is config file change in this PR. Please help test. Just the key for now
/cc @hyunsun in the configmap the keys need to change at the minimum and network names sts/net-attach-def charts need to change.

s1u -> access
sgi -> core

@krsna1729
Copy link
Member

@ajamshed can you rebase, squash and force push a single commit.

... to access-, core- respectively.
Also updated the README file.

Signed-off-by: Muhammad Asim Jamshed <[email protected]>
@yoooou
Copy link

yoooou commented Aug 3, 2020

@yoooou there is config file change in this PR. Please help test. Just the key for now
/cc @hyunsun in the configmap the keys need to change at the minimum and network names sts/net-attach-def charts need to change.

s1u -> access
sgi -> core

IIUC testing this patch needs some change in helm-charts repo? If so can anyone submit a helm chart patch which I can download for testing this patch?

@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

5 similar comments
@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

@yoooou
Copy link

yoooou commented Aug 3, 2020

retest this please

@krsna1729 krsna1729 merged commit 8a62e37 into master Aug 3, 2020
@krsna1729 krsna1729 deleted the topics/rename_modules branch August 3, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants