Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design document for DNN-based UPF selection #293

Merged
merged 12 commits into from
Sep 30, 2024

Conversation

anaswarac-dac
Copy link
Contributor

This pull request implements DNN-based UPF selection, allowing the SMF to select UPFs based on both DNN and Slice ID.

Reason for changes

This change is necessary to support scenarios where multiple DNNs are used within the same Slice ID, ensuring the correct UPF is selected based on the DNN.

@gab-arrobo
Copy link
Contributor

@anaswarac-dac,

Thanks for opening this PR, here are a couple comments:

  1. Do you think a PR in the smf repo is the most appropriate place for this document? What about opening a couple of issues (one in the upf repo and one in the smf? Additionally (or alternatively), this can be added to the roadmap.
  2. When opening a PR, you need to commit your changes with signoff as indicated here. Every action has to pass before a PR can be merged.

@thakurajayL
Copy link
Contributor

@gab-arrobo we can add the 1 liner bullet in Roadmap. I wanted to have some design folder with proposals.


### 3.1. SMF Changes
- **SMF UPF Selection Logic:**
- Identify the code where SMF performs UPF selection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide mode details and rephrase the lines to reflect that what we intend to do. Line (1) seems to something study line 2, 3 is something about proposed code change. You need to work on this PR more to refine it further

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if this provides the clarity you were looking for or if there are any additional details you need.

mcc: "001"
mnc: "01"
site-name: "enterprise"
upf:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where it limits one UPF per Slice.. We need changes in this config so that it remains backward compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upf field has been replaced by upfs to accommodate multiple UPF definitions. Each UPF is specified as an item in a list, with its own upf-name and upf-port

Signed-off-by: anaswara <[email protected]>
@gab-arrobo gab-arrobo merged commit 3efe680 into omec-project:master Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants