-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design document for DNN-based UPF selection #293
Add design document for DNN-based UPF selection #293
Conversation
Thanks for opening this PR, here are a couple comments:
|
@gab-arrobo we can add the 1 liner bullet in Roadmap. I wanted to have some design folder with proposals. |
design/upf-selection-design.md
Outdated
|
||
### 3.1. SMF Changes | ||
- **SMF UPF Selection Logic:** | ||
- Identify the code where SMF performs UPF selection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide mode details and rephrase the lines to reflect that what we intend to do. Line (1) seems to something study line 2, 3 is something about proposed code change. You need to work on this PR more to refine it further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if this provides the clarity you were looking for or if there are any additional details you need.
0407d54
to
7435af0
Compare
design/upf-selection-design.md
Outdated
mcc: "001" | ||
mnc: "01" | ||
site-name: "enterprise" | ||
upf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where it limits one UPF per Slice.. We need changes in this config so that it remains backward compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upf field has been replaced by upfs to accommodate multiple UPF definitions. Each UPF is specified as an item in a list, with its own upf-name and upf-port
ae92a9e
to
2a5040a
Compare
2a5040a
to
5b5d6ce
Compare
5b5d6ce
to
0d137f4
Compare
Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]> Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]>
Updated Co-authored-by: Ajay Lotan Thakur <[email protected]> Signed-off-by: anaswara <[email protected]>
Updated Co-authored-by: Ajay Lotan Thakur <[email protected]> Signed-off-by: anaswara <[email protected]>
Updated Co-authored-by: Ajay Lotan Thakur <[email protected]> Signed-off-by: anaswara <[email protected]>
Updated Co-authored-by: Ajay Lotan Thakur <[email protected]> Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]>
Signed-off-by: anaswara <[email protected]>
This pull request implements DNN-based UPF selection, allowing the SMF to select UPFs based on both DNN and Slice ID.
Reason for changes
This change is necessary to support scenarios where multiple DNNs are used within the same Slice ID, ensuring the correct UPF is selected based on the DNN.