CI: Copy node exe to runner workspace root, don't abort macOS matrix

olive-editor · Dec 4, 2024 · baac1f5 · baac1f5
1 parent 15ded22
commit baac1f5
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -54,13 +54,11 @@ jobs:
 
     steps:
       - name: Install Node.js 16
-        id: node16
         run: |
           $DOWNLOAD_TOOL https://nodejs.org/dist/v16.20.2/node-v16.20.2-linux-x64.tar.xz
           tar -xf node-v16.20.2-linux-x64.tar.xz
-          node16="$(pwd)/node-v16.20.2-linux-x64/bin/node"
-          $node16 --version
-          echo "executable=${node16}" >> $GITHUB_OUTPUT
+          cp -a ./node-v16.20.2-linux-x64/bin/node '${{ runner.workspace }}/node16'
+          '${{ runner.workspace }}/node16' --version
 
       - name: Checkout Source Code
         env:
@@ -72,7 +70,7 @@ jobs:
           $DOWNLOAD_TOOL https://raw.githubusercontent.com/actions/checkout/refs/tags/v3/dist/index.js
           $DOWNLOAD_TOOL https://raw.githubusercontent.com/actions/checkout/refs/tags/v3/dist/problem-matcher.json
           cd ..
-          ${{ steps.node16.outputs.executable }} ./checkout-v3/index.js
+          '${{ runner.workspace }}/node16' ./checkout-v3/index.js
         #uses: actions/checkout@v3
         #with:
         #  submodules: true
@@ -155,11 +153,11 @@ jobs:
           INPUT_PATH: 'build/Olive*.AppImage'
           INPUT_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          mkdir upload-artifacts-v3
-          cd upload-artifacts-v3
+          mkdir upload-artifact-v3
+          cd upload-artifact-v3
           $DOWNLOAD_TOOL https://raw.githubusercontent.com/actions/upload-artifact/refs/tags/v3/dist/index.js
           cd ..
-          ${{ steps.node16.outputs.executable }} ./upload-artifacts-v3/index.js
+          '${{ runner.workspace }}/node16' ./upload-artifact-v3/index.js
         continue-on-error: true
         #uses: actions/upload-artifact@v3
         #with:
@@ -320,6 +318,7 @@ jobs:
 
   macos:
     strategy:
+      fail-fast: false
       matrix:
         include:
           - build-type: RelWithDebInfo