Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules init #89

Merged
merged 10 commits into from
Oct 22, 2021
Merged

Modules init #89

merged 10 commits into from
Oct 22, 2021

Conversation

dvdherron
Copy link
Contributor

Description

  • Removes the Init module from Accoutrement
  • Recommends CSS Remedy as an alternative reset.

@dvdherron
Copy link
Contributor Author

I want Accoutrement on Sass Modules

@dvdherron dvdherron changed the base branch from main to modules October 18, 2021 16:00
@dvdherron dvdherron marked this pull request as ready for review October 19, 2021 13:05
@dvdherron dvdherron requested a review from mirisuzanne October 19, 2021 13:05
@dvdherron
Copy link
Contributor Author

@mirisuzanne If we just want to link to CSS Remedy, I think this is ready to be reviewed before being merged into modules

mirisuzanne
mirisuzanne approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Do you think it might make sense to keep the historic init changelog link, or nah?

CHANGELOG.md Outdated
Comment on lines 341 to 347
- [Accoutrement Init][io]
- [Accoutrement Color][co]
- [Accoutrement Layout][lo]
- [Accoutrement Scale][so]
- [Accoutrement Type][to]

[io]: https://github.com/oddbird/accoutrement-init/blob/master/CHANGELOG.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep these, since they're just linking to historic documentation? I don't have a strong feeling either way.

Copy link
Contributor Author

@dvdherron dvdherron Oct 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne True. I think it makes sense to keep those around. Added them back in and removed the oddsite link I missed initially.

@mirisuzanne
Copy link
Member

I want Accoutrement on Sass Modules

@mirisuzanne mirisuzanne merged commit 8763a02 into modules Oct 22, 2021
@mirisuzanne mirisuzanne deleted the modules-init branch October 22, 2021 16:39
@dvdherron dvdherron mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirisuzanne mirisuzanne mirisuzanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdherron @mirisuzanne