Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration fixes #8

Merged
merged 3 commits into from
Mar 9, 2025
Merged

Configuration fixes #8

merged 3 commits into from
Mar 9, 2025

Conversation

plaffitt
Copy link
Contributor

This fixes 3 issues:

  • I removed flags default values in order to prevent environment variable being overwritten by them.
  • I merged the user defined configuration with the default one, so one can use a config file that doesn't define all configuration entries without crashing.
  • I removed some dead code.

I figured out that using confuse as proposed in the issue would require to change a lot of code since confuse doesn't allow to parse configuration into custom objects. So I came up with something lighter that doesn't need to install any additional library.

Closes #7

@obeone
Copy link
Owner

obeone commented Mar 9, 2025

Thank you very much for this PR!

Sorry for taking so long to take care of it...

@obeone obeone merged commit e0c73fb into obeone:main Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues configuring the tool
2 participants