Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info WRT installing on Alpine Linux / Busybox #1106

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Add info WRT installing on Alpine Linux / Busybox #1106

merged 1 commit into from
Jun 3, 2016

Conversation

neilstuartcraig
Copy link
Contributor

As discussed in #1102

ljharb
ljharb reviewed May 31, 2016
View reviewed changes
README.markdown
@@ -302,6 +302,24 @@ Shell settings:
set -e
```

## Installing NVM on Alpine Linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's lowercase nvm throughout, sorry i didn't catch that before :-)

@ljharb
Copy link
Member

ljharb commented May 31, 2016

LGTM pending tweaks, and a fresh squash/rebase

@ljharb ljharb added informational needs followup We need some info or action from whoever filed this issue/PR. needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean. labels May 31, 2016
@neilstuartcraig
Lowercase NVM
337ddba 
Lowercase NPM

Ref @mhart

Add information WRT installling on Alpine Linux
@neilstuartcraig
Copy link
Contributor Author

@ljharb - how's that looking now? I think I caught everything and hopefully the rebase has been OK for this PR.

@ljharb
Copy link
Member

ljharb commented Jun 1, 2016

@neilstuartcraig i don't see any changes pushed up - you may need to force push?

@neilstuartcraig
Copy link
Contributor Author

@ljharb - Do you not see the additions here?
https://github.com/creationix/nvm/tree/36322b62fa7629d1b5c8af1b6c76312fc73d2004

I rebased then did git push origin master --force but I may have messed up something...Happy to try again or create a fresh PR if you can't see it.

Cheers

@ljharb
Copy link
Member

ljharb commented Jun 2, 2016

@neilstuartcraig ah - this PR is from the branch patch-1, not from master, so you want git push origin patch-1 --force instead :-)

@neilstuartcraig
Copy link
Contributor Author

Ah, sorry @ljharb - should be sorted now. I was trying to keep it simple by using the online/web PR system but that gets confusing when you try to instead push from your machine.

Hopefully that'll do the job but let me know if not and i'll make a fresh PR.

Cheers :-)

@ljharb ljharb removed needs followup We need some info or action from whoever filed this issue/PR. needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean. labels Jun 3, 2016
@ljharb ljharb merged commit 20c551c into nvm-sh:master Jun 3, 2016
@ljharb ljharb modified the milestone: v0.31.2 Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
informational
Projects
None yet
Milestone
v0.31.2
Development

Successfully merging this pull request may close these issues.
2 participants
@neilstuartcraig @ljharb