Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvm install --reinstall-packages-from uses aliased cd #1284

Closed
ilkka opened this issue Nov 3, 2016 · 2 comments
Closed

nvm install --reinstall-packages-from uses aliased cd #1284

ilkka opened this issue Nov 3, 2016 · 2 comments
Assignees
@ljharb
Labels
bugs Oh no, something's broken :-( shell alias clobbering Anything dealing with users shadowing builtins with aliases or functions.

Comments

@ilkka
Copy link

ilkka commented Nov 3, 2016 •
edited
Loading

I'm using zsh and b4b4r07/enhancd and therefore have the alias cd=__enhancd::cd in my shell. This morning I installed v6.9 with

$ nvm install v6 --reinstall-packages-from=v6.7.0

and either just before or after outputting

Linking global packages from v6.7.0...

I noticed the enhancd UI popping up in the terminal. Dunno what's doing the cd but probably it should take care to use the builtin.
@ljharb ljharb added bugs Oh no, something's broken :-( shell alias clobbering Anything dealing with users shadowing builtins with aliases or functions. labels Nov 3, 2016
@ljharb ljharb self-assigned this Nov 3, 2016
@ljharb
Copy link
Member

ljharb commented Nov 3, 2016

Thanks! Fix incoming.

@ljharb
Copy link
Member

ljharb commented Nov 3, 2016

So it turns out I've actually tried this before, and zsh craps out with command cd - I'll try to use \cd and bypass shellcheck.

@ljharb ljharb closed this as completed in 942e9ab Nov 3, 2016
edwmurph pushed a commit to edwmurph/nvm that referenced this issue Apr 9, 2018
@ljharb
[Fix] bypass aliased cd in a few places.
015000e 
Fixes nvm-sh#1284.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljharb ljharb

Labels
bugs Oh no, something's broken :-( shell alias clobbering Anything dealing with users shadowing builtins with aliases or functions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilkka @ljharb