checkin for rule attribute no-loop #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevSide
reviewed
Oct 1, 2016
There was a problem hiding this comment.
It does not work as expected, no-loop avoid only self-loop recursion.
function Message() {
this.state = 0;
}
var flow = nools.flow("noLoop1", function () {
this.rule("Rule 1: State from 0 to 1 and from 2 to nothing", { noLoop: true }, [Message, "m"], function (facts) {
var m = facts.m;
if(m.state == 0) {
m.state = 1;
this.modify(m);
} else {
// nothing
}
});
this.rule("Rule 2: State from 1 to 2", [Message, "m", "m.state == 1"], function (facts) {
var m = facts.m;
m.name = 'Hello World 2';
m.state = 2;
this.modify(m);
});
});
In this exemple, we expect firing "Rule 1" -> "Rule 2" -> "Rule 1"
| @@ -94,6 +94,20 @@ var ruleTokens = { | |||
| }; | |||
| })(), | |||
|
|
|||
| noLoop: (function () { | |||
| var noLoopRegexp = /^(noLoop|no-loop)\s*:\s*(-?true|false)\s*[,;]?/; | |||
| @@ -227,6 +227,8 @@ var Rule = declare({ | |||
| this.name = name; | |||
| this.pattern = pattern; | |||
| this.cb = cb; | |||
| this.noLoop = options.noLoop; | |||
| @@ -37,6 +37,7 @@ Or [download the source](https://raw.github.com/C2FO/nools/master/nools.js) ([mi | |||
| * [Structure](#rule-structure) | |||
| * [Salience](#rule-salience) | |||
| * [Scope](#rule-scope) | |||
| * [no-loop](#rule-no-loop) | |||
Open
|
I made another PR to move forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Doug, starting over on the pull requests with a cleaner history and a more factored aproach.