Add custom constraint using function and resolve types in scope #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doug-martin Any chance to review this PR? |
|
👍 |
|
@raymondfeng Thanks for the PR, Ill take a look tonight and try to get a release out! |
|
@doug-martin Thanks! |
|
👍 |
doug-martin
added a commit
to doug-martin/nools
that referenced
this pull request
Feb 25, 2015
* Fix for issue noolsjs#122 referencing defined class within another defined class * Also fixes accessing scoped functions within a defined class. * Fix for issue noolsjs#119 window was removed from the nools.js file now it is called in the current scope of `this`. * Allow session.halt even for `match()` noolsjs#143 - @raymondfeng * Now if you call `halt()` even if you did not call `matchUntilHalt()` * Now you can use a function as a constraint (Only applies to rules defined programatically) noolsjs#142 - @raymondfeng * You can now define types using scope [noolsjs#142](noolsjs#142) - @raymondfeng * Fix for issue, is the dsl you do not have to escape `\` characters noolsjs#123
Merged
doug-martin
added a commit
to doug-martin/nools
that referenced
this pull request
Feb 25, 2015
* Fix for issue noolsjs#122 referencing defined class within another defined class * Also fixes accessing scoped functions within a defined class. * Fix for issue noolsjs#119 window was removed from the nools.js file now it is called in the current scope of `this`. * Allow session.halt even for `match()` noolsjs#143 - @raymondfeng * Now if you call `halt()` even if you did not call `matchUntilHalt()` * Now you can use a function as a constraint (Only applies to rules defined programatically) noolsjs#142 - @raymondfeng * You can now define types using scope [noolsjs#142](noolsjs#142) - @raymondfeng * Fix for issue, is the dsl you do not have to escape `\` characters noolsjs#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds two things:
options.scopeMotivations:
We try to use
noolsas the rules engine for LoopBack's policy framework. LoopBack has its own JSON format to describe rules/constraints/actions that will be transformed to the formats consumable bynools.