fix: Fix retry-handler.js when retry-after header is a Date #4084
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Mar 6, 2025
| @@ -124,7 +124,7 @@ class RetryHandler { | |||
| if (retryAfterHeader) { | |||
| retryAfterHeader = Number(retryAfterHeader) | |||
| retryAfterHeader = Number.isNaN(retryAfterHeader) | |||
| ? calculateRetryAfterHeader(retryAfterHeader) | |||
| ? calculateRetryAfterHeader(headers['retry-after']) | |||
There was a problem hiding this comment.
Let's add a proper check and parsing for it
I also fixed the related test; it now waits only 1ms, even though the date parser has failed. In fact Number(iso-date) has become NaN on function to evaluate retry-after header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Fix retry-handler when retry-after header is a Date
Changes
Fix using original header retry-after for calculate timeout instead header casted to Number
Bug Fixes
Fix using original header retry-after for calculate timeout instead header casted to Number
Status