Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: change createReadStream to fs.createReadStream #7511

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

GaneshS288
Copy link
Contributor

Description

Changes

const readStream = createReadStream(filePath, { encoding: 'utf8' });

to

const readStream = fs.createReadStream(filePath, { encoding: 'utf8' });

Validation

Screenshot taken by locally running the site with npm run dev

image

Related Issues

#7510

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@GaneshS288 GaneshS288 requested a review from a team as a code owner February 25, 2025 08:44
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 25, 2025 8:45am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your contribution

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 75 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 87 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.75% (742/836) 76.1% (242/318) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 6.045s ⏱️

@AugustinMauroy AugustinMauroy added the fast-track Fast Tracking PRs label Feb 25, 2025
@AugustinMauroy
Copy link
Member

cc @nodejs/nodejs-website I'm fast-tracking because it's just fixing a snippet

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Feb 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 25, 2025
@AugustinMauroy AugustinMauroy added this pull request to the merge queue Feb 25, 2025
Merged via the queue into nodejs:main with commit ebc0e82 Feb 25, 2025
29 of 31 checks passed
@GaneshS288 GaneshS288 deleted the createReadStream_typo_fix branch March 1, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants