Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handle for unwrap in 'src/crypto/crypto_keys.cc` #56899

Closed
wooffie opened this issue Feb 3, 2025 · 0 comments · Fixed by #56900
Closed

Adding handle for unwrap in 'src/crypto/crypto_keys.cc` #56899

wooffie opened this issue Feb 3, 2025 · 0 comments · Fixed by #56900

Comments

@wooffie
Copy link
Contributor

wooffie commented Feb 3, 2025

Version

main

Platform

any

Subsystem

crypto

What steps will reproduce the bug?

Should we add check for Unwrap here?

KeyObjectHandle* handle = Unwrap<KeyObjectHandle>(args[0].As<Object>());

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reporter: Burkov Egor ([email protected]).

Organization: R-Vision ([email protected]).

wooffie added a commit to wooffie/node that referenced this issue Feb 3, 2025
wooffie added a commit to wooffie/node that referenced this issue Feb 3, 2025
targos pushed a commit that referenced this issue Feb 11, 2025
Fixes: #56899
PR-URL: #56900
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this issue Feb 23, 2025
Fixes: nodejs#56899
PR-URL: nodejs#56900
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant