squash: adjust tests

nodejs · Sep 22, 2023 · 27a0ad9 · 27a0ad9
1 parent 7d40cb5
commit 27a0ad9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -588,12 +588,17 @@ function openAsBlob(path, options, callback) {
   validateObject(options, 'options');
   const type = options.type || '';
   validateString(type, 'options.type');
+  validateFunction(callback, 'cb');
 
   let blob;
   let cbError = null;
   try {
     blob = createBlobFromFilePath(pathModule.toNamespacedPath(path), { type });
   } catch (err) {
+    // Permission errors should be thrown instead of being passed to callback
+    if (err.code === 'ERR_ACCESS_DENIED') {
+      throw err;
+    }
     cbError = err;
   }
   callback(cbError, blob);

diff --git a/test/fixtures/permission/fs-read.js b/test/fixtures/permission/fs-read.js
@@ -253,7 +253,7 @@ const regularFile = __filename;
 // fs.openAsBlob
 {
   assert.throws(() => {
-    fs.openAsBlob(blockedFile);
+    fs.openAsBlob(blockedFile, () => {});
   }, common.expectsError({
     code: 'ERR_ACCESS_DENIED',
     permission: 'FileSystemRead',

diff --git a/test/parallel/test-blob-file-backed.js b/test/parallel/test-blob-file-backed.js
@@ -9,7 +9,7 @@ const {
 const { TextDecoder } = require('util');
 const {
   writeFileSync,
-  openAsBlob,
+  promises: { openAsBlob },
 } = require('fs');
 
 const {

diff --git a/test/parallel/test-permission-fs-supported.js b/test/parallel/test-permission-fs-supported.js
@@ -36,7 +36,7 @@ const supportedApis = [
   ...syncAndAsyncAPI('mkdir'),
   ...syncAndAsyncAPI('mkdtemp'),
   ...syncAndAsyncAPI('open'),
-  'openAsBlob',
+  ...syncAndAsyncAPI('openAsBlob'),
   ...syncAndAsyncAPI('mkdtemp'),
   ...syncAndAsyncAPI('readdir'),
   ...syncAndAsyncAPI('readFile'),